----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/#review124289 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On March 17, 2016, 11:33 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44655/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 11:33 p.m.) > > > Review request for mesos, Ben Mahler and Gilbert Song. > > > Bugs: MESOS-4949 > https://issues.apache.org/jira/browse/MESOS-4949 > > > Repository: mesos > > > Description > ------- > > If `ExecutorInfo.shutdown_grace_period` is set, the executor > driver uses it, otherwise it falls back to the environment > variable `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`. > > > Diffs > ----- > > docs/configuration.md d10fa2e7fc7c477de2f0e30e10da6d817ecbf404 > include/mesos/executor/executor.proto > ae211194a44e0bf2fadc79e833881e45ea3eb2c2 > include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b > include/mesos/v1/executor/executor.proto > 36a2b3f9bc3aaa524f655b9e686a6d33512e6aaa > include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b > src/slave/containerizer/containerizer.cpp > f6fc7863d0c215611f170dc0c89aa229407b5137 > src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > > Diff: https://reviews.apache.org/r/44655/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >