----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44964/ -----------------------------------------------------------
Review request for mesos and Jie Yu. Repository: mesos Description ------- This mostly targets unnecessary inclusion of stout headers, which can be quite expensive to compile. Diffs ----- src/credentials/credentials.hpp aad17c21bb0ce98907bbfa22b890b66130e081e4 src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e src/tests/group_tests.cpp ed10f1fe8a5cd2a353175e13ec3c464da69956f4 src/tests/master_contender_detector_tests.cpp bbce379e5a0a0ca608579d0ab2b10970e9cd5ef1 src/tests/mesos.hpp 93b9340d94d91663283fe5df5ad9febe69ffd2a3 src/tests/module_tests.cpp eddb0e5484964595797758e2742b10431e76c039 src/tests/paths_tests.cpp 7952ae239470580f06df373c80f9115634b42640 src/tests/script.cpp 36ddf40fc003435f852ca138f66c4f33def1637b src/tests/state_tests.cpp 8fb2798e12fe77d6b93268e71e3a8261cb0842d5 src/tests/status_update_manager_tests.cpp 801767ba6b4a08a4f653a7735bf3a581a0f8f95f src/tests/zookeeper_test_server.hpp e2d8218fd7000904acaee2221da648c665da8dfc src/zookeeper/group.cpp 7aa95a7b7eafe0a2c49dc077b3a4abd688e5d8e8 Diff: https://reviews.apache.org/r/44964/diff/ Testing ------- `make check` Timed the compilation of a few files to verify the compilation time improvement -- e.g., removing an unused include of `stout/os.hpp` reduces compile time by ~1 second on my laptop. Thanks, Neil Conway
