----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44080/#review124228 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (line 529) <https://reviews.apache.org/r/44080/#comment186686> Can we just do `using ::gmtime_r;`? 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 177) <https://reviews.apache.org/r/44080/#comment186687> Can we remove the `struct` in `struct tm`? 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (lines 179 - 184) <https://reviews.apache.org/r/44080/#comment186685> Why not just ```cpp return ::gmtime_s(result, timep) == ERROR_SUCCESS ? result : NULL; ``` ? - Michael Park On March 14, 2016, 8:48 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44080/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 8:48 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4462 > https://issues.apache.org/jira/browse/MESOS-4462 > > > Repository: mesos > > > Description > ------- > > Windows:[1/2] Implemented `os::gmtime_r`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 9ee233b988c08d953e70345c55bcdd5c2f7c101b > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > 6a391ff198ab724f689bcef79d4e2e05a786cbc2 > > Diff: https://reviews.apache.org/r/44080/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
