----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124157 -----------------------------------------------------------
Fix it, then Ship it! Only minor nits src/slave/flags.cpp (line 678) <https://reviews.apache.org/r/44515/#comment186566> ... unauthenticated requests to HTTP endpoints are also allowed. (otherwise it could be read as "requests to unauthenticated HTTP endpoints are also allowed") src/slave/flags.cpp (lines 683 - 684) <https://reviews.apache.org/r/44515/#comment186567> "Path to a JSON-formatted file containing credentials used to authenticate HTTP endpoints on the slave." src/slave/flags.cpp (line 686) <https://reviews.apache.org/r/44515/#comment186568> You can just say "Example:", since you don't have a "Text file Example" too. src/slave/slave.cpp (line 338) <https://reviews.apache.org/r/44515/#comment186571> `s/_http_credentials/credentials/` At the very least, you should use trailing underscore here instead of leading underscore. But you have the opportunity to not use a trailing underscore at all, so take it. - Adam B On March 17, 2016, 12:41 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44515/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 12:41 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Till > Toenshoff. > > > Bugs: MESOS-4849 > https://issues.apache.org/jira/browse/MESOS-4849 > > > Repository: mesos > > > Description > ------- > > Added agent flags for HTTP authentication. > > Three command-line flags have been added to the agent to enable HTTP > authentication: `--authenticate_http`, `--http_credentials`, and > `--http_authenticators`. > > > Diffs > ----- > > src/slave/constants.hpp 4189c07dbad754e51f1a067ecbb4c99ae42a386f > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 > src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 > src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 > > Diff: https://reviews.apache.org/r/44515/diff/ > > > Testing > ------- > > `sudo make check` was used to test on both OSX and Ubuntu 14.04. > > > Thanks, > > Greg Mann > >
