> On March 15, 2016, 8:35 p.m., Ben Mahler wrote: > > Could you add a corresponding test? Having it in the header should make > > this really easy :)
Sure, but I'll write a more complex test than just unit testing the validation function. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/#review123743 ----------------------------------------------------------- On March 15, 2016, 3:47 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44707/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 3:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4909 > https://issues.apache.org/jira/browse/MESOS-4909 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > > Diff: https://reviews.apache.org/r/44707/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >