----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44992/#review124294 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer.hpp (line 74) <https://reviews.apache.org/r/44992/#comment186769> If you're moving this line, can you remove the >> space here to avoid more churn? src/tests/containerizer.hpp (line 91) <https://reviews.apache.org/r/44992/#comment186767> Seems this shouldn't be documented here, unless this isn't overriding the interface? Looks like this is just an implementation of the interface function, where it is already documented. - Ben Mahler On March 17, 2016, 11:47 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44992/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 11:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > The common pattern is to follow the order in the parent class. > > > Diffs > ----- > > src/tests/containerizer.hpp 67fbe7fedbe170c3f22a2dcbb5aebf4195a5aabc > > Diff: https://reviews.apache.org/r/44992/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
