----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review124434 -----------------------------------------------------------
Per discussion in https://reviews.apache.org/r/45003/, if we can actually run into `FTS_SLNONE`, we should have a test-case for it. 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp (line 50) <https://reviews.apache.org/r/45002/#comment186997> This merits a comment explaining why we're setting `FTS_PHYSICAL`, I think. - Neil Conway On March 18, 2016, 12:16 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45002/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 12:16 a.m.) > > > Review request for mesos, Jie Yu and Neil Conway. > > > Repository: mesos > > > Description > ------- > > According to the documentation for fts_open, either FTS_PHYSICAL or > FTS_LOGICAL > SHOULD be provided. We need FTS_PHYSICAL for the case of rmdir as we dont want > to resolve the symlink targets while deleting them. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > cbc97596cd8ed1e6d4261568fd0086c86e063232 > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp > daa46e05d113fd62ea9dad042ec41aaab28ad003 > > Diff: https://reviews.apache.org/r/45002/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
