Re: Review Request 44421: Added support for "overlay" keyword.

[Jie Yu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44421/#review124206
-----------------------------------------------------------




src/linux/fs.hpp (lines 160 - 161)
<https://reviews.apache.org/r/44421/#comment186656>

    Please use namespace instead.
    
    ```
    namespace overlay {
    
    Try<bool> supported();
    
    } // namespace overlay {
    ```



src/linux/fs.cpp (line 71)
<https://reviews.apache.org/r/44421/#comment186657>

    Please put '{' to a new line.



src/linux/fs.cpp (line 74)
<https://reviews.apache.org/r/44421/#comment186658>

    Remove this line? I would do:
    ```
    Try<bool> overlay = fs::supported("overlay");
    if (overlay.isError()) {
      return Error("...");
    } else if (overlay.get() == true) {
      return true;
    }
    
    Try<bool> overlayfs = fs::supported("overlayfs");
    if (overlayfs.isError()) {
      return Error("...");
    } else if (overlayfs.get() == true) {
      return true;
    }
    
    return false;
    ```


- Jie Yu


On March 11, 2016, 11:58 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44421/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin.
> 
> 
> Bugs: MESOS-4874
>     https://issues.apache.org/jira/browse/MESOS-4874
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The "overlayfs" was renamed to "overlay" in kernel 4.2, for overlay
> support check function, it should check both "overlay" and "overlayfs"
> in "/proc/filesystems".
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 55652540e35f9c451ad85cfead575a788aa3eba1 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 5cc0f8b5a8cd4c945023f874056a8184113186c5 
>   src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 
> 
> Diff: https://reviews.apache.org/r/44421/diff/
> 
> 
> Testing
> -------
> 
> root@mesos002:~/src/mesos/m1/mesos/build# uname -r
> 4.2.3-040203-generic
> root@mesos002:~/src/mesos/m1/mesos/build# lsmod  | grep over
> overlay                45056  1 
> root@mesos002:~/src/mesos/m1/mesos/build# cat /proc/filesystems | grep over
> nodev overlay
> root@mesos002:~/src/
> 
> make
> make check
> ./bin/mesos-tests.sh 
> --gtest_filter="OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>