----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44082/#review124263 -----------------------------------------------------------
Is this the right approach for all of them? https://reviews.apache.org/r/44081 introduces the `setPaths` function in `stout/os.hpp` (not `stout/posix/os.hpp`), which uses `setenv`. If `setenv` is marked `= delete`, then this will be a compiler error. It seems that the intent may have been to say, "if `setPaths` is __used__, then it should be a compiler error since `setPaths` uses `setenv` which is marked `= delete`. This is not true. I think perhaps what we want is to mark `setPaths` also `= delete` for Windows? Please help me understand! :) - Michael Park On March 14, 2016, 9:12 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44082/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 9:12 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > ------- > > Stout: Un-commented out functions and marked them as deleted instead. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > 6a391ff198ab724f689bcef79d4e2e05a786cbc2 > > Diff: https://reviews.apache.org/r/44082/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
