----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review124451 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 82) <https://reviews.apache.org/r/44514/#comment187020> s/NetworkResultInfo/Info/ We typically use 'Info' to store information about each container in isolators. We can then have a hashmap from network name to a another data structure in Info to represent the networks the container has joined. ``` // Information about a network that a container has joined. struct NetworkInfo { string ifname; cni::NetworkResult result; }; struct Info { hashmap<string, NetworkInfo> networkInfos; }; ``` - Jie Yu On March 18, 2016, 6:31 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44514/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 6:31 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44514/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >