> On March 21, 2016, 1:20 p.m., haosdent huang wrote: > >
Thanks for reviewing haosdent! > On March 21, 2016, 1:20 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp, line 31 > > <https://reviews.apache.org/r/45022/diff/1/?file=1305010#file1305010line31> > > > > I notice most cases we still use `isDirectory`, so I am not sure which > > style should use here. Feel free drop me if this style is correct here. We're trying to get to `snake_case` in stout and libprocess. Hopefully one day Mesos as well :-) > On March 21, 2016, 1:20 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp, line 46 > > <https://reviews.apache.org/r/45022/diff/1/?file=1305010#file1305010line46> > > > > Should it add > > ``` > > NOLINT(whitespace/line_length) > > ``` > > at then end of this line? Does the linter complain on this? I thought it excepted URLS? - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124540 ----------------------------------------------------------- On March 18, 2016, 7:39 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45022/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 7:39 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-4415 > https://issues.apache.org/jira/browse/MESOS-4415 > > > Repository: mesos > > > Description > ------- > > We currently depend on arcane "POSIX-like" Windows APIs like `::remove`. > This API is incompatible with NT paths -- which we will eventually have > to transition to for the Windows integration -- and has no documented > behavior interacting with subsystems like the driver subsystem, which is > required for symlinks. > > This commit will move us to proper core Windows API equivalents for > `::remove`. > > Review: https://reviews.apache.org/r/45022 > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 7bd4bfbc2ec5922879dcefddc12137336b11be52 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rm.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp > 52568b303c03fd57b81f6cc67782444ce734dd41 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp > 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83 > > Diff: https://reviews.apache.org/r/45022/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
