> On March 18, 2016, 11:24 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 3357 > > <https://reviews.apache.org/r/44994/diff/2/?file=1306236#file1306236line3357> > > > > Why do you resume?
I think we *should* resume the clock before exiting the test. I've heard plans to even add a check in our test harness that verified the clock is not paused. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/#review124308 ----------------------------------------------------------- On March 18, 2016, 5:13 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44994/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 5:13 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4949 > https://issues.apache.org/jira/browse/MESOS-4949 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 > > Diff: https://reviews.apache.org/r/44994/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > `make check` > `GLOG_v=2 GTEST_FILTER="*SlaveTest*" ./bin/mesos-tests.sh --gtest_repeat=100 > --gtest_break_on_failure` > > > Thanks, > > Alexander Rukletsov > >
