> On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 302-303 > > <https://reviews.apache.org/r/44948/diff/4/?file=1307750#file1307750line302> > > > > We typically store the 'flags' directory in case yo u need other > > parameters in the future.
Since I don't need all the flags, it seems better to just store the one I want. If I needed more than one flag, I agree that storing the whole thing probably makes sense. > On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 394 > > <https://reviews.apache.org/r/44948/diff/4/?file=1307750#file1307750line394> > > > > Can you have a LOG(ERROR) here? ``cleanupDirectory`` has already logged this error. > On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 320 > > <https://reviews.apache.org/r/44948/diff/4/?file=1307750#file1307750line320> > > > > I am wondering if it's possible to distinguish the Error case from the > > case where there's no project ID assigned to the directory. > > > > Can we make xfs::getProjectId(...) return a Result? If there's no project ID assigned, you get a successful ``Try`` with a value of ``0``. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review124486 ----------------------------------------------------------- On March 21, 2016, 9:47 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44948/ > ----------------------------------------------------------- > > (Updated March 21, 2016, 9:47 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOs-4828 > https://issues.apache.org/jira/browse/MESOs-4828 > > > Repository: mesos > > > Description > ------- > > Track sandbox directory usage by dynamically assigning XFS project > quotas. We track a range of XFS project IDs, assigning a project ID > and a project quota to each sandbox as it is created. When the task > reaches the quota, writes will fail with EDQUOT, and the task will have > an opportunity to handle that. > > Quotas are not applied to volume resources since the isolator interface > has no insight into the volume lifecycle. Thus it is not currently > possible to accurately assign and reclaim project IDs. > > If LOW is the lower bound of the project ID range and HIGH is the upper > bound, you can show the currently allocated project quotas using the > xfs_quota command: > > $ xfs_quota -x -c "report -a -n -L LOW -U HIGH" > > To show the project ID assigned to the file PATH, use the xfs_io command: > > $ xfs_io -r -c stat PATH > > > Diffs > ----- > > src/Makefile.am 9dd21b56af0500f7125b07bf535b45fe5c544aaf > src/slave/containerizer/mesos/containerizer.cpp > ee7a265975323ca891114a286357c8e42901560c > src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3 > > Diff: https://reviews.apache.org/r/44948/diff/ > > > Testing > ------- > > Make check. Manual testing. Tests in subsequent patches. > > > Thanks, > > James Peach > >
