----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/#review124806 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 151) <https://reviews.apache.org/r/45082/#comment187489> I guess if we are going to use `attach` for connecting to networks, lets use `detach` over here. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 554) <https://reviews.apache.org/r/45082/#comment187492> Calling dispatch on itself I think can be avoided. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 644 - 645) <https://reviews.apache.org/r/45082/#comment187494> These two CHECKS don't make sense. What if the plugin got deleted or there was a bug in the plugin because of which it wasn't able to delete the interfaces or release the IP addresses. The Agent should not die because of an error in a 3rd party plugin. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 647 - 649) <https://reviews.apache.org/r/45082/#comment187496> This is a bit odd, __disconnect always returns an error ? The plugin can return error codes and error logs which we should be propagating upstream through failure semantics. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 653) <https://reviews.apache.org/r/45082/#comment187498> Why are we returning a Future<list<Nothing>> over here? We should be returning a Future<Nothing> there is no list since you are deletnig the entire container directory in one shot. This seems a bit odd. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 686) <https://reviews.apache.org/r/45082/#comment187497> This is dangerous we should be returning a const reference passed down in the call as a return argument. Just do a return list<Nothing>() over here. PS: Please see my comment on returning Future<list<Nothing>> above. - Avinash sridharan On March 20, 2016, 4:30 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45082/ > ----------------------------------------------------------- > > (Updated March 20, 2016, 4:30 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Implemented cleanup() method of "network/cni" isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45082/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
