> On 三月 22, 2016, 2:23 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 395 > > <https://reviews.apache.org/r/44674/diff/1/?file=1294669#file1294669line395> > > > > Just a question: Where did set the schema was set to `https` for this > > case? > > Gilbert Song wrote: > Hey Guangya, we set `https` as default in /uri/fetchers/docker.cpp: > > DockerFetcherPluginProcess::getManifestUri() > DockerFetcherPluginProcess::getBlobUri()
Thanks Gilbert, got it. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review124793 ----------------------------------------------------------- On 三月 17, 2016, 4:57 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44674/ > ----------------------------------------------------------- > > (Updated 三月 17, 2016, 4:57 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4939 > https://issues.apache.org/jira/browse/MESOS-4939 > > > Repository: mesos > > > Description > ------- > > Supported image name specified with private registry prefix. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6d637ed14f35feb554c8fcc63a7a7e046aaca574 > > Diff: https://reviews.apache.org/r/44674/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-test.sh --gtest_filter="ProvisionerDockerRegistryPullerTest" > > Tested with private registry localhost:80/ubuntu > > > Thanks, > > Gilbert Song > >
