----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/ -----------------------------------------------------------
(Updated March 23, 2016, 2:46 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, haosdent huang, Neil Conway, and Deshi Xiao. Changes ------- Skipped .md scan based on feedback from haosdent and Deshi. Bugs: MESOS-4033 https://issues.apache.org/jira/browse/MESOS-4033 Repository: mesos Description (updated) ------- This review request tries to add a commit hook for checking non-ascii characters. It scans .cpp, .hpp, .cc, .h files and report error if non-ascii characters exists. As part of this review request, two non-ascii characters are identified in versioning.md (one in Ln 85 and another in Ln 96) and are corrected accordingly. Note: .md scan is skipped based on feedback from review request. Diffs (updated) ----- docs/versioning.md ecacd8433f0fa1643827b36d03154042538c1c6b support/hooks/post-rewrite e3747a320fef0b71c06bcf0f2c5532958c416646 support/hooks/pre-commit 10838a4c99db2a8318d64f95d90d2c2c90150453 support/non-ascii.py PRE-CREATION Diff: https://reviews.apache.org/r/45033/diff/ Testing ------- Tested manually and found two non ascii characters in docs/versioning.md (fixed as part of this review request). Thanks, Yong Tang