----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review125186 -----------------------------------------------------------
Fix it, then Ship it! Thanks! CHANGELOG (line 6) <https://reviews.apache.org/r/44661/#comment187974> this is in another review, but s/log/long/ CHANGELOG (line 7) <https://reviews.apache.org/r/44661/#comment187975> this is in another review, but s/htting/hitting/ CHANGELOG (lines 8 - 9) <https://reviews.apache.org/r/44661/#comment187976> It is the executor's responsiblitity to enforce kill policies - Ben Mahler On March 23, 2016, 11:26 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44661/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 11:26 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Bugs: MESOS-4910 > https://issues.apache.org/jira/browse/MESOS-4910 > > > Repository: mesos > > > Description > ------- > > Instead, a combination of `executor_shutdown_grace_period` > agent flag and task kill policies should be used. > > > Diffs > ----- > > CHANGELOG 1fadaa1819c9b1a801752b1c0ddd572b82e6c170 > docs/configuration.md 73ee8fa7a77a6ceaf44e1f4c54ab4027a7109258 > src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 > src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 > src/slave/flags.hpp 3067c128f1fded4f130f4d45f191584c2f30ad9c > src/slave/flags.cpp ce028825ad99f54a231b4b18dde277b63aa0525c > > Diff: https://reviews.apache.org/r/44661/diff/ > > > Testing > ------- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
