----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45304/#review125377 -----------------------------------------------------------
Patch looks great! Reviews applied: [45304] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 24, 2016, 6:42 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45304/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 6:42 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5015 > https://issues.apache.org/jira/browse/MESOS-5015 > > > Repository: mesos > > > Description > ------- > > This fix changes Call and Event Type enums in executor.proto > optional for the purpose of backwards compatibility. (MESOS-5015) > > > Diffs > ----- > > include/mesos/executor/executor.proto > ae211194a44e0bf2fadc79e833881e45ea3eb2c2 > include/mesos/v1/executor/executor.proto > 36a2b3f9bc3aaa524f655b9e686a6d33512e6aaa > src/examples/test_http_executor.cpp > 562b0acfd8555b9b773175f53defe0e7e2744641 > src/tests/mesos.hpp aaef158e5784ce077ef60996ebbeb77b356b7c57 > > Diff: https://reviews.apache.org/r/45304/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >