----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45327/#review125378 -----------------------------------------------------------
Fix it, then Ship it! LGTM, just some minor code comments. src/scheduler/scheduler.cpp (line 547) <https://reviews.apache.org/r/45327/#comment188161> Let's keep the wording consistent with the executor library. ```cpp // This could happen if the master libprocess process has not yet set up HTTP routes. ``` Also was missing a period at the end. src/scheduler/scheduler.cpp (line 554) <https://reviews.apache.org/r/45327/#comment188162> ```cpp // This could happen if the detector detects a new leading master before master itself realizes it (e.g., ZK watch delay). ``` - Anand Mazumdar On March 24, 2016, 11:21 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45327/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 11:21 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5020 > https://issues.apache.org/jira/browse/MESOS-5020 > > > Repository: mesos > > > Description > ------- > > This fix drops `404 Not Found` and `307 Temporary Redirect` in > the scheduler library, instead of treating them as Event::ERROR. > (MESOS-5020) > > > Diffs > ----- > > src/scheduler/scheduler.cpp 1f52a423c8c83c58d38ba6731ab2625136a271bb > > Diff: https://reviews.apache.org/r/45327/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
