----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/#review125468 -----------------------------------------------------------
Regarding testing: The upgrade script doesn't really test ZK upgrade because it doesn't bring up ZK server (there's a TODO for that). Can you update the upgrade script to add ZK support (basically bring up ZK and let masters, agents and framework talk to it)? You can add that as a separate review to this chain. 3rdparty/Makefile.am (line 54) <https://reviews.apache.org/r/44376/#comment188265> Does this comment still apply? AFAICT MESOS-1797 doesn't apply to ZK 3.4.8 since that issue has been resolved in ZK 3.4.7. 3rdparty/zookeeper-3.4.8.patch (lines 1 - 19) <https://reviews.apache.org/r/44376/#comment188266> Is this a fix for PPC? Can you explain what the problem and fix is? I would recommend to split this patch into 2 patches 1) Just for ZK upgrade to 3.4.8 2) Patch create/update for PPC src/tests/zookeeper_test_server.cpp (line 142) <https://reviews.apache.org/r/44376/#comment188267> Have you confirmed that this is still an issue with ZK 3.4.8? - Vinod Kone On March 24, 2016, 12:33 p.m., Zhiwei Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44376/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 12:33 p.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4612 > https://issues.apache.org/jira/browse/MESOS-4612 > > > Repository: mesos > > > Description > ------- > > Upgrade zookeeper to 3.4.8 to support PowerPC LE platform. > > > Diffs > ----- > > 3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717 > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > 3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3 > 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da > 3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc > 3rdparty/zookeeper-3.4.8.patch PRE-CREATION > src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 > src/python/native_common/ext_modules.py.in > c335bd83024bc07b6243dd59d775e7f29adc7520 > src/tests/zookeeper_test_server.cpp > 0dc041fef8973d35114b9f76a6a4002853884670 > > Diff: https://reviews.apache.org/r/44376/diff/ > > > Testing > ------- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
