----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44791/#review125511 -----------------------------------------------------------
Ship it! - Joris Van Remoortere On March 14, 2016, 3:45 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44791/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 3:45 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-4839 > https://issues.apache.org/jira/browse/MESOS-4839 > > > Repository: mesos > > > Description > ------- > > Previously the Error behavior (in particular where the child process is > killed) was not consistent among Error cases. > We should establish the convention that the Hook itself returns an error, > while the subprocess code is resposible for > killing the child process in case of such Error. > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess.cpp > 16c327db6fde1a1bac92d9e8f7cc80e57b028c1a > > Diff: https://reviews.apache.org/r/44791/diff/ > > > Testing > ------- > > sudo make check (on Linux) > > > Thanks, > > Joerg Schad > >
