----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45313/#review125538 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 30) <https://reviews.apache.org/r/45313/#comment188385> The constructor should be WindowsErrorBase 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 33) <https://reviews.apache.org/r/45313/#comment188386> Constructor name == WindowsErrorBase 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 105) <https://reviews.apache.org/r/45313/#comment188388> Make the constructor public 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 113) <https://reviews.apache.org/r/45313/#comment188389> Make the constructor public 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 115) <https://reviews.apache.org/r/45313/#comment188391> This shoulf be WindowsSocketError - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45313/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp > 64102e1f31437d4271a1126e339fb2f33f0181b8 > > Diff: https://reviews.apache.org/r/45313/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
