----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45311/#review125548 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp (line 33) <https://reviews.apache.org/r/45311/#comment188403> With this default parameter the code has to be changed on every place where we return or handle a WindowsError object. One sugestion is to use different defaults on Windows and Posix and handle the conversion from ErrnoError/Error to WindowsError inside WindowsError class. - Daniel Pravat On March 24, 2016, 8:23 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45311/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 8:23 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > c444c0118d39ee6a5da4618d7c62784464377280 > > Diff: https://reviews.apache.org/r/45311/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
