----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45249/#review125611 -----------------------------------------------------------
Oops. Found a bug! src/tests/files_tests.cpp (line 81) <https://reviews.apache.org/r/45249/#comment188483> Don't you need to call `TemporaryDirectoryTest::TearDown();` at the end of this? - Adam B On March 25, 2016, 5:07 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45249/ > ----------------------------------------------------------- > > (Updated March 25, 2016, 5:07 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Joerg Schad. > > > Bugs: MESOS-4956 > https://issues.apache.org/jira/browse/MESOS-4956 > > > Repository: mesos > > > Description > ------- > > A new test was added (FilesTest.AuthenticationTest) to probe the `/files/*` > endpoints' behavior when HTTP authentication is enabled. > > > Diffs > ----- > > src/tests/files_tests.cpp b3894954e32b14f879f24fac17869fc32ad2ce0e > > Diff: https://reviews.apache.org/r/45249/diff/ > > > Testing > ------- > > `sudo make check` and `GTEST_FILTER="FilesTest.AuthenticationTest" > build/bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure=1` were > used to test on OSX and CentOS 7. > > > Thanks, > > Greg Mann > >
