-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45397/#review125745
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/Makefile.am (line 61)
<https://reviews.apache.org/r/45397/#comment188597>

    Update the comment.



3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch (line 10)
<https://reviews.apache.org/r/45397/#comment188598>

    Do you know why the non-ssl build didn't have a problem with this conflict?
    
    Also, the real fix is for stout to namespace its flags (e.g., stout::flags) 
implementation instead of fixing the library. But I don't know how big of a 
change is that.


- Vinod Kone


On March 28, 2016, 9:08 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45397/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 9:08 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed name of http-parser enum to 'flags_enum'.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> 04a4cf4241b8188c093f4942d27b050fa7b20397 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 385302a491aba5a38ff74c0debfc2a423b0c5a8a 
>   3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45397/diff/
> 
> 
> Testing
> -------
> 
> `../configure --enable-libevent --enable-ssl && make check` was used to text 
> on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to