----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44361/#review125965 -----------------------------------------------------------
Fix it, then Ship it! configure.ac (line 215) <https://reviews.apache.org/r/44361/#comment188888> NVML configure.ac (line 221) <https://reviews.apache.org/r/44361/#comment188889> s/libs/libraries/ ? configure.ac (lines 948 - 955) <https://reviews.apache.org/r/44361/#comment188891> Could we tell the user explicitly when the path is absolute? - Ben Mahler On March 14, 2016, 7:37 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44361/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 7:37 a.m.) > > > Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. > > > Bugs: MESOS-4861 > https://issues.apache.org/jira/browse/MESOS-4861 > > > Repository: mesos > > > Description > ------- > > This is the initial commit to begin adding native support for GPUs in > Mesos. This initial version will only include support for Nvidia GPUs > that can be managed by the Nvidia Management Library (nvml). > > The configure flags added in this commit can be used to enable Nvidia > GPU support, as well as specify the installation directories of the > nvml header and library files if not already installed in standard > include/library paths on the system. > > In a subsequent commit, we will use these configure flags to > conditionally build support for Nvidia GPUs into Mesos. > > > Diffs > ----- > > configure.ac 8e4f03593df4a8ba13f00292963e351acc3f71c1 > > Diff: https://reviews.apache.org/r/44361/diff/ > > > Testing > ------- > > I ran `bootstrap` to generate configure. > > I then ran: > > ``` > mkdir build; cd build > ../configure --enable-nvidia-gpu-support > ../configure --enable-nvidia-gpu-support --with-nvml-include=<path_to_headers> > ../configure --enable-nvidia-gpu-support --with-nvml-include=<bogus_path> > ../configure --enable-nvidia-gpu-support --with-nvml-lib=<path_to_lib> > ../configure --enable-nvidia-gpu-support --with-nvml-lib=<bogus_path> > ../configure --enable-nvidia-gpu-support --with-nvml-include=<bogus_path> > --with-nvml-lib=<path_to_lib> > ../configure --enable-nvidia-gpu-support > --with-nvml-include=<path_to_headers> --with-nvml-lib=<bogus_path> > ../configure --enable-nvidia-gpu-support --with-nvml-include=<bogus_path> > --with-nvml-lib=<bogus_path> > ../configure --enable-nvidia-gpu-support > --with-nvml-include=<path_to_headers> --with-nvml-lib=<path_to_lib> > ``` > > And verified the proper errors / successes in each case (only the last one is > a success). > > The exact command I ran in the success case for my configuration was: > ``` > ../configure --enable-nvidia-gpu-support > --with-nvml-include=/opt/nvidia-gdk/usr/include > --with-nvml-lib=/opt/nvidia-gdk/usr/src/gdk/nvml/lib > ``` > > > Thanks, > > Kevin Klues > >
