----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44365/#review125985 -----------------------------------------------------------
Fix it, then Ship it! docs/configuration.md (lines 1308 - 1309) <https://reviews.apache.org/r/44365/#comment188908> Could we add something to clarify that this is relevant when "gpus" are specified within --resources? - Ben Mahler On March 14, 2016, 7:38 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44365/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 7:38 a.m.) > > > Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. > > > Bugs: MESOS-4864 > https://issues.apache.org/jira/browse/MESOS-4864 > > > Repository: mesos > > > Description > ------- > > Added flag to specify available Nvidia GPUs on an agent's command line. > > > Diffs > ----- > > docs/configuration.md 739d4ff9aeeb1ba70ce11033168d63d37b6ef56b > src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 > src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd > > Diff: https://reviews.apache.org/r/44365/diff/ > > > Testing > ------- > > ./bin/mesos-slave.sh --master=127.0.0.1:5050 --nvidia_gpu_devices=1,2,string > Failed to load flag 'nvidia_gpu_devices': Failed to load value '1,2,string': > Expecting all elements to be unsigned integers > > ./bin/mesos-slave.sh --master=127.0.0.1:5050 --nvidia_gpu_devices=1,2.0,3 > Failed to load flag 'nvidia_gpu_devices': Failed to load value '1,2,3.0': > Expecting all elements to be unsigned integers > > ./bin/mesos-slave.sh --master=127.0.0.1:5050 --nvidia_gpu_devices=1,2,3 > SUCCESS > > > Thanks, > > Kevin Klues > >
