----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45202/#review126281 -----------------------------------------------------------
Patch looks great! Reviews applied: [45202] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 31, 2016, 7:15 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45202/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 7:15 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4881 > https://issues.apache.org/jira/browse/MESOS-4881 > > > Repository: mesos > > > Description > ------- > > Add test for rescinding offer trriggered by updating weights. > > > Diffs > ----- > > src/tests/dynamic_weights_tests.cpp > 6357cf42ec59c1388e95d6d808978918d5cd4a78 > src/tests/master_allocator_tests.cpp > b41ba2bda4d680f6fc42f525719973d56c11fe31 > src/tests/mesos.hpp a35371d7c1fcb9dbbe8a18c80522deb6bf789ad8 > > Diff: https://reviews.apache.org/r/45202/diff/ > > > Testing > ------- > > make && make check. > > $ ./src/mesos-tests > --gtest_filter=MasterAllocatorTest/0.RebalancedForUpdatedWeights > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from MasterAllocatorTest/0, where TypeParam = > mesos::internal::master::allocator::MesosAllocator<mesos::internal::master::allocator::HierarchicalAllocatorProcess<mesos::internal::master::allocator::DRFSorter, > mesos::internal::master::allocator::DRFSorter> > > [ RUN ] MasterAllocatorTest/0.RebalancedForUpdatedWeights > [ OK ] MasterAllocatorTest/0.RebalancedForUpdatedWeights (1059 ms) > [----------] 1 test from MasterAllocatorTest/0 (1059 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1070 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Yongqiao Wang > >
