----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45537/#review126318 -----------------------------------------------------------
src/tests/environment.cpp (lines 767 - 771) <https://reviews.apache.org/r/45537/#comment189270> should this be done by the test event listener as well? src/tests/environment.cpp (line 776) <https://reviews.apache.org/r/45537/#comment189269> s/std::string/string/ ? src/tests/environment.cpp (line 813) <https://reviews.apache.org/r/45537/#comment189268> why std::string? - Vinod Kone On March 31, 2016, 12:17 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45537/ > ----------------------------------------------------------- > > (Updated March 31, 2016, 12:17 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-5044 > https://issues.apache.org/jira/browse/MESOS-5044 > > > Repository: mesos > > > Description > ------- > > Updated testing `Environment` to remove temp dirs after each test. > > > Diffs > ----- > > src/tests/environment.hpp 9932f7c530dee3180bbbdf6c06e1e0ec424b46b9 > src/tests/environment.cpp 7617e43587cb81104786d06f753f08565a6c2d0a > > Diff: https://reviews.apache.org/r/45537/diff/ > > > Testing > ------- > > Verified that make check doesn't leak any temporary directories. > The exception seems to be some mesos-XXXXX directories created by example > frameworks. > > > Thanks, > > Joris Van Remoortere > >
