----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/#review126329 -----------------------------------------------------------
src/master/contenders/contender.hpp (line 42) <https://reviews.apache.org/r/44544/#comment189296> This doesn't seem to be used here. src/master/contenders/contender.hpp (line 50) <https://reviews.apache.org/r/44544/#comment189294> `mesos/master/contender.hpp` has not been included for MasterContender. Can you fix this? src/master/contenders/contender.hpp (line 56) <https://reviews.apache.org/r/44544/#comment189299> Can you insert a newline before this one? src/master/contenders/contender.cpp (line 25) <https://reviews.apache.org/r/44544/#comment189292> This should come near the top. src/master/contenders/contender.cpp (lines 58 - 61) <https://reviews.apache.org/r/44544/#comment189301> I am not sure if I understand this one here. Can you elaborate a bit? src/master/contenders/contender.cpp (line 72) <https://reviews.apache.org/r/44544/#comment189303> We can kill spaces between `> > >` here. src/master/detectors/detector.hpp (line 39) <https://reviews.apache.org/r/44544/#comment189304> Kill the newline. - Kapil Arya On March 23, 2016, 7:05 p.m., Anurag Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44544/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 7:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-4610 > https://issues.apache.org/jira/browse/MESOS-4610 > > > Repository: mesos > > > Description > ------- > > Moved contender and detector definitions into separate directories. > > > Diffs > ----- > > src/master/contenders/contender.hpp PRE-CREATION > src/master/contenders/contender.cpp PRE-CREATION > src/master/detectors/detector.hpp PRE-CREATION > src/master/detectors/detector.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/44544/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/44670/. > > > Thanks, > > Anurag Singh > >
