----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45580/#review126658 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 564) <https://reviews.apache.org/r/45580/#comment189669> I won't add this LOG(INFO) since the bind mount logging implies this. src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1032 - 1033) <https://reviews.apache.org/r/45580/#comment189670> You should put this log line in the if block. - Jie Yu On April 1, 2016, 9:54 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45580/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 9:54 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-4759 > https://issues.apache.org/jira/browse/MESOS-4759 > > > Repository: mesos > > > Description > ------- > > Add some log messages in 'network/cni' isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 486c382365d5293cd9d53b8b239f70a543c46792 > > Diff: https://reviews.apache.org/r/45580/diff/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >