----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45200/#review126661 -----------------------------------------------------------
Can you call this out in the CHANGELOG too please? Also, all of the old flags should print a deprecation warning (when a user does --help on the binary or starts the binary with a deprecated flag) and direct users to the new flags. Can you make that change? - Vinod Kone On March 23, 2016, 7:39 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45200/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 7:39 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > [https://issues.apache.org/jira/browse/MESOS-3781] > > > Diffs > ----- > > src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c > src/master/flags.hpp f8d2cc4c6c8dab00e34ca737dbcb5b9ca3870d6d > src/master/flags.cpp e6fea6421ea1a16b9cd78b0e42b830829b95ad61 > src/tests/flags_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45200/diff/ > > > Testing > ------- > > ./configure --with-network-isolator > make check > > > Thanks, > > Jay Guo > >
