> On April 3, 2016, 11:40 p.m., Michael Park wrote: > > Why did you replace `AWAIT_ASSERT_EQ(true/false` only? Why not > > `EQ(true/false` in general, so that we would catch the use of > > `EXPECT_SOME_EQ(true, expr);` in `src/tests/health_check_tests.cpp` for > > example? > > Is there perhaps a separate patch that I don't have a pointer to? > > Yong Tang wrote: > Thanks Michael. I was not sure when I did the change. Let me update the > review request shortly. > > Michael Park wrote: > Ah, ok. Thanks!
Hi Michael, I tried to update the review request. However, it seems that the commit hook will not allow me to modify libprocess and mesos at the same time. As a result, I have to create two separate commit to add item (5) of MESOS-4112, then change `_EQ(true/false` to `_TRUE/_FALSE` (which makes the current review request https://reviews.apache.org/r/45356/ obsolete). The list of corect related review requests for MESOS-4112 are now in: https://reviews.apache.org/r/45357/ https://reviews.apache.org/r/45664/ https://reviews.apache.org/r/45663/ Please take a look and let me know if there are any issues. In the meantime, I will close the current review request https://reviews.apache.org/r/45356/. Thanks a lot for the review. - Yong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45356/#review126762 ----------------------------------------------------------- On March 26, 2016, 10:35 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45356/ > ----------------------------------------------------------- > > (Updated March 26, 2016, 10:35 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4112 > https://issues.apache.org/jira/browse/MESOS-4112 > > > Repository: mesos > > > Description > ------- > > This RR is a follow up to MESOS-4112 to replace `AWAIT_ASSERT_EQ(true/false` > with the newly defined `AWAIT_ASSERT_TRUE/_FALSE`. > > > Diffs > ----- > > src/tests/cram_md5_authentication_tests.cpp > 67f74e208ce138dc1e4667af108af3538b34aee9 > src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 > src/tests/group_tests.cpp ed10f1fe8a5cd2a353175e13ec3c464da69956f4 > src/tests/registrar_tests.cpp 39caf9bb950c0b229a66becb039c7a830a18f6bc > > Diff: https://reviews.apache.org/r/45356/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
