----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/#review126791 -----------------------------------------------------------
Ditto to the v1. Thanks, Guangya! include/mesos/mesos.proto (line 1563) <https://reviews.apache.org/r/45214/#comment189865> +1. include/mesos/mesos.proto (line 1576) <https://reviews.apache.org/r/45214/#comment189866> Let's make it 0.30. include/mesos/mesos.proto (line 1581) <https://reviews.apache.org/r/45214/#comment189867> ditto. include/mesos/mesos.proto (lines 1597 - 1600) <https://reviews.apache.org/r/45214/#comment189871> Would we possibly have more fields in this message? If no, I guess we may want `repeated string driver_option = 3` only below. BTW, if we want to keep this msg, could we clarify more detail in comment (e.g., add an example in \'\')? include/mesos/mesos.proto (line 1605) <https://reviews.apache.org/r/45214/#comment189872> Newline above. include/mesos/mesos.proto (line 1607) <https://reviews.apache.org/r/45214/#comment189873> ditto. - Gilbert Song On April 1, 2016, 10:41 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45214/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 10:41 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5012 > https://issues.apache.org/jira/browse/MESOS-5012 > > > Repository: mesos > > > Description > ------- > > Updated protobuf to support external storage. > > > Diffs > ----- > > include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f > include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 > > Diff: https://reviews.apache.org/r/45214/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
