-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43284/
-----------------------------------------------------------
(Updated April 4, 2016, 5:23 p.m.)
Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
Changes
-------
Rebase.
Bugs: MESOS-5075
https://issues.apache.org/jira/browse/MESOS-5075
Repository: mesos
Description
-------
Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.
Diffs (updated)
-----
src/tests/containerizer/isolator_tests.cpp
7e16846e97e20a7ef058dd8ae4664fa1c554283d
Diff: https://reviews.apache.org/r/43284/diff/
Testing
-------
Without this patch, when running
```
sudo GLOG_v=1 ./bin/mesos-tests.sh
--gtest_filter="PerfEventIsolatorTest.ROOT_CGROUPS_Sample" --verbose
```
, would got this error
```
[----------] Global test environment tear-down
../../src/tests/environment.cpp:732: Failure
Failed
Tests completed with child processes remaining:
-+- 16501 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
|-+- 16580 /home/haosdent/mesos/build/src/.libs/lt-mesos-tests
--gtest_filter=PerfEventIsolatorTest.ROOT_CGROUPS_Sample --verbose
| -+- 16582 perf stat --all-cpus --field-separator , --log-fd 1 --event cycles
--cgroup mesos/239d30bb-f7a1-413b-9d99-0914149d5899 --event task-clock --cgroup
mesos/239d30bb-f7a1-413b-9d99-0914149d5899 -- sleep 0.25
| --- 16584 sleep 0.25
--- 16581 ()
[==========] 1 test from 1 test case ran. (4095 ms total)
```
This also fix similar error in
`MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward` and
`CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
Thanks,
haosdent huang
