> On April 6, 2016, 9:07 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp, line 407 > > <https://reviews.apache.org/r/44948/diff/15/?file=1327115#file1327115line407> > > > > Should we assume that freeProjectId already doesn't include > > `info->projectId`?
No, ``freeProjectIds`` is initialized from ``totalProjectIds``, so we have to remove it because it is still considered in use. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/#review127367 ----------------------------------------------------------- On April 6, 2016, 6:43 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44948/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 6:43 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOs-4828 > https://issues.apache.org/jira/browse/MESOs-4828 > > > Repository: mesos > > > Description > ------- > > Track sandbox directory usage by dynamically assigning XFS project > quotas. We track a range of XFS project IDs, assigning a project ID > and a project quota to each sandbox as it is created. When the task > reaches the quota, writes will fail with EDQUOT, and the task will have > an opportunity to handle that. > > Quotas are not applied to volume resources since the isolator interface > has no insight into the volume lifecycle. Thus it is not currently > possible to accurately assign and reclaim project IDs. > > If LOW is the lower bound of the project ID range and HIGH is the upper > bound, you can show the currently allocated project quotas using the > xfs_quota command: > > $ xfs_quota -x -c "report -a -n -L LOW -U HIGH" > > To show the project ID assigned to the file PATH, use the xfs_io command: > > $ xfs_io -r -c stat PATH > > > Diffs > ----- > > src/Makefile.am 55d3b341361bed25f3aa966d77060c88be29e5b0 > src/slave/containerizer/mesos/containerizer.cpp > a5dd22380066aa85de04d485052084e2629681c0 > src/slave/containerizer/mesos/isolators/xfs/disk.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/xfs/disk.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION > src/slave/flags.hpp 69e1b01e09d2a15bee5e0745b751f47aaefe3fbe > src/slave/flags.cpp 315cf47d268bce0a0255a061d64e414c736c8125 > > Diff: https://reviews.apache.org/r/44948/diff/ > > > Testing > ------- > > Make check. Manual testing. Tests in subsequent patches. > > > Thanks, > > James Peach > >
