> On 四月 6, 2016, 6:15 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 2089-2092 > > <https://reviews.apache.org/r/45808/diff/1/?file=1327488#file1327488line2089> > > > > we always use braces around our if and else blocks. > > > > if () { > > > > } else { > > > > }
Good to know the rule here. Thanks! - fan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45808/#review127391 ----------------------------------------------------------- On 四月 6, 2016, 8:59 a.m., fan du wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45808/ > ----------------------------------------------------------- > > (Updated 四月 6, 2016, 8:59 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-4981 > https://issues.apache.org/jira/browse/MESOS-4981 > > > Repository: mesos > > > Description > ------- > > This change will cover three cases: > 1. Directly call {re}registerFramework > 2. Through HTTP call > 3. Through MesosSchedulerDriver > > Suggested by Benjamin Mahler to introspect framework_info.id. > > > Diffs > ----- > > src/master/master.cpp 2cfa5075991bbb5df8a7e33b14767de558bda4ac > > Diff: https://reviews.apache.org/r/45808/diff/ > > > Testing > ------- > > 1. I can use 'docker-no-executor-framework' to reproduce/verify the issue. > > "master/messages_register_framework": 1.0, > "master/messages_reregister_framework": 0.0, > > > Thanks, > > fan du > >
