----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review127636 -----------------------------------------------------------
3rdparty/libprocess/src/subprocess.cpp (line 67) <https://reviews.apache.org/r/45491/#comment191020> I think we could use `os::chdir` here? ``` inline Try<Nothing> chdir(const std::string& directory) { if (::chdir(directory.c_str()) < 0) { return ErrnoError(); } return Nothing(); } ``` 3rdparty/libprocess/src/subprocess.cpp (line 441) <https://reviews.apache.org/r/45491/#comment191021> Because abort here, should we use `ERROR` level? - haosdent huang On April 7, 2016, 4:55 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45491/ > ----------------------------------------------------------- > > (Updated April 7, 2016, 4:55 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-5070 > https://issues.apache.org/jira/browse/MESOS-5070 > > > Repository: mesos > > > Description > ------- > > Previously the subprocess interface supported a several options for the > child process such as setsid. In order to make the interface more > flexible we refactored such options into a vector of ChildHooks. > In order not to allow arbitrary code inside a ChildHook it has to be > constructed via pre-defined factory methods. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 5435ddda1fd7dfcff1a0b28f2abe35feb707ceeb > 3rdparty/libprocess/include/process/subprocess.hpp > 8a3fe5526f480187441a8aee2c72636bec3e2b2d > 3rdparty/libprocess/src/subprocess.cpp > bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > 727e940f12643974de4ff2734fba431b285b5de3 > > Diff: https://reviews.apache.org/r/45491/diff/ > > > Testing > ------- > > Tested entire chain see https://reviews.apache.org/r/45495/. > > > Thanks, > > Joerg Schad > >
