----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44893/#review127894 -----------------------------------------------------------
Does mesos compile after applying this patch? If not, I would rather not split the patch. Yes, we prefer smaller patches, but each of them should be an atomic change, instead of just splitting a large patch into smaller pieces. There's no point of doing that. Could you please merge those non-atomic changes into one patch? Otherwise, it's hard to reason what have you done. - Jie Yu On April 3, 2016, 2:12 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44893/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 2:12 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till > Toenshoff, and Timothy Chen. > > > Bugs: MESOS-5086 > https://issues.apache.org/jira/browse/MESOS-5086 > > > Repository: mesos > > > Description > ------- > > Remove fetcher header file in containerizer.hpp. > > > Diffs > ----- > > src/local/local.cpp 06f6118a5038149f87e970b5cdf7987a270d3fae > src/slave/containerizer/containerizer.hpp > ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf > src/slave/containerizer/docker.hpp 89d450e10a84f24ddd46d517e2b4b46ab02c4fda > src/slave/containerizer/mesos/containerizer.hpp > a6e3a8b43fb7591ff6f23b019a062696c8bfb719 > src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa > > Diff: https://reviews.apache.org/r/44893/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
