----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45614/#review128554 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp (line 29) <https://reviews.apache.org/r/45614/#comment191990> `return ErrnoError()` if this fails? Same for ::closesocket(). - Alex Naparu On April 2, 2016, 6:35 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45614/ > ----------------------------------------------------------- > > (Updated April 2, 2016, 6:35 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex > Clemmer, Joris Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented os::close for Windows. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp > 1c912c3edc815e7e0b1a562286279897d773a516 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1 > > Diff: https://reviews.apache.org/r/45614/diff/ > > > Testing > ------- > > OSX: make check > > > Thanks, > > Daniel Pravat > >