> On April 13, 2016, midnight, Gilbert Song wrote: > > src/tests/slave_tests.cpp, line 790 > > <https://reviews.apache.org/r/46121/diff/1/?file=1342073#file1342073line790> > > > > use `os::getcwd()` to make consensus with other tests launching > > containers.
After thinking about this a bit more, I'm hesitant to use os::getcwd() since it makes an implicit assumption about the test being within a sandbox. Ideally the cwd comes from the test fixture or environment abstractions to ensure that the test is indeed using a temporary directory. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46121/#review128578 ----------------------------------------------------------- On April 12, 2016, 11:15 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46121/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 11:15 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > This leads to test failures when multiple invocations are occuring on the > machine, or if root ownes /tmp/stdout. > > > Diffs > ----- > > src/tests/slave_tests.cpp 9e9dc35c6f03291648ec451581f762b1ab8b5a8d > > Diff: https://reviews.apache.org/r/46121/diff/ > > > Testing > ------- > > make check (previously was failing due to /tmp/stdout being owned by root) > > > Thanks, > > Ben Mahler > >
