> On 四月 5, 2016, 5:47 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 110 > > <https://reviews.apache.org/r/45370/diff/4/?file=1324030#file1324030line110> > > > > ``` > > foreach (const string& driverOption, > > volume.source().docker_volume().driver_options()) { > > driverOptions += " --volumeopts=" + driverOption; > > } > > ```
This is now changed to `Parameters` > On 四月 5, 2016, 5:47 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 62 > > <https://reviews.apache.org/r/45370/diff/4/?file=1324030#file1324030line62> > > > > How about use `which` when it avaiable? > > https://issues.apache.org/jira/browse/MESOS-4576 Sometimes the `dvdcli` may not in `PATH` and we may not able to use `which` to get the dvdcli path. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review127145 ----------------------------------------------------------- On 四月 14, 2016, 6:06 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45370/ > ----------------------------------------------------------- > > (Updated 四月 14, 2016, 6:06 a.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() for volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45370/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
