----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46149/#review128883 -----------------------------------------------------------
Bad patch! Reviews applied: [46149] Failed command: ./support/apply-review.sh -n -r 46149 Error: 2016-04-14 12:46:50 URL:https://reviews.apache.org/r/46149/diff/raw/ [1757/1757] -> "46149.patch" [1] Total errors found: 0 Checking 1 files Error: No line in the commit message summary may exceed 72 characters. Full log: https://builds.apache.org/job/mesos-reviewbot/12524/console - Mesos ReviewBot On April 13, 2016, 3:20 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46149/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 3:20 p.m.) > > > Review request for mesos, Benjamin Bannier and Michael Park. > > > Bugs: MESOS-5166 > https://issues.apache.org/jira/browse/MESOS-5166 > > > Repository: mesos > > > Description > ------- > > **Phenomenon**: The runtime of "ExamplesTest.DynamicReservationFramework" is > ~13s > **Root Cause**: In dynamic reservation example, the framework will accept > offer when reserving resources, launching tasks and unreserving tasks. The > un-used resources will return to allocator with 5s RefusedFilters. It impact > the performance of this example. > **How to Fix**: Set filters.refused_timeout to zero when launching task, > reserving/unreserving resources. > > > Diffs > ----- > > src/examples/dynamic_reservation_framework.cpp > 8f00bcf50c25cf46c3dc32e3e77370b39fbd46bc > > Diff: https://reviews.apache.org/r/46149/diff/ > > > Testing > ------- > > make && make check GTEST_FILTER="ExamplesTest.*" > > [==========] Running 5 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 5 tests from ExamplesTest > [ RUN ] ExamplesTest.TestFramework > [ OK ] ExamplesTest.TestFramework (5252 ms) > [ RUN ] ExamplesTest.NoExecutorFramework > [ OK ] ExamplesTest.NoExecutorFramework (5407 ms) > [ RUN ] ExamplesTest.TestHTTPFramework > [ OK ] ExamplesTest.TestHTTPFramework (1265 ms) > [ RUN ] ExamplesTest.PersistentVolumeFramework > [ OK ] ExamplesTest.PersistentVolumeFramework (3379 ms) > [ RUN ] ExamplesTest.DynamicReservationFramework > [ OK ] ExamplesTest.DynamicReservationFramework (5127 ms) > [----------] 5 tests from ExamplesTest (20433 ms total) > > [----------] Global test environment tear-down > [==========] 5 tests from 1 test case ran. (20443 ms total) > [ PASSED ] 5 tests. > > > Thanks, > > Klaus Ma > >
