----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45922/#review129089 -----------------------------------------------------------
src/local/local.cpp (line 393) <https://reviews.apache.org/r/45922/#comment192554> Move this comment to line 398 src/local/local.cpp (line 398) <https://reviews.apache.org/r/45922/#comment192555> ``` authorizer_, // Same authorizer as master. ``` src/slave/slave.hpp (line 108) <https://reviews.apache.org/r/45922/#comment192559> I think is a better practice to move optional parameters at the end and default initialize them to `None()`. In fact if you check `master.hpp` it is how it is done there. src/tests/mesos.cpp (line 468) <https://reviews.apache.org/r/45922/#comment192560> This is what I meant. If this were at the end and default initialize, you wouldn't have to define it. - Alexander Rojas On April 14, 2016, 6:51 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45922/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 6:51 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-5142 > https://issues.apache.org/jira/browse/MESOS-5142 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/configuration.md ce51f26f0584eeecb5c96e39a5bcc21f5906a29c > src/local/local.cpp df72ac52110b75d63df1076496b48e63d06d42ce > src/slave/constants.hpp 9978c11fec40055dd42f19c20cd3e9fef4e78cea > src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a > src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 > src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 > src/slave/slave.hpp f78c1b4e4d5378ef7223c6eb3ea45491c30fb4c1 > src/slave/slave.cpp de99e9eb5cc812b2e07deb749b98b4f4db363728 > src/tests/cluster.hpp 887342acc72b33b4c904d610da47394f9a7d7188 > src/tests/cluster.cpp b4d69106388892b88f7de20b248cac8b950b861c > src/tests/mesos.cpp 1b7a8fd703b90d77ffa3df079bdc2744752caac6 > > Diff: https://reviews.apache.org/r/45922/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
