----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46255/#review129093 -----------------------------------------------------------
Fix it, then Ship it! src/tests/mesos.hpp (line 101) <https://reviews.apache.org/r/46255/#comment192563> Change to `constexpr char DEFAULT_HTTP_AUTHENTICATION_REALM[] = "test-realm"` - Alexander Rojas On April 15, 2016, 8:55 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46255/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 8:55 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > ------- > > In order to enable authentication on libprocess-level > HTTP endpoints, this patch adds code to the master and > agent's main.cpp file which makes use of the new > `authenticationRealm` argument to `process::initialize` > which allows the authentication realm of such endpoints > to be set when libprocess is initialized. The argument is > added to libprocess initialization in the tests as well. > > > Diffs > ----- > > src/master/main.cpp ea7f0fc87c8912309a4679105dde5d8d5bb9ead6 > src/slave/main.cpp 70df4f384b09a1fb078cd893efe52a5e3b116f48 > src/tests/main.cpp 142585096493a334ac9ac0df511ae0fc10798040 > src/tests/mesos.hpp 20370a277d55efeea8daae7ea5e2f6575b5a2d62 > > Diff: https://reviews.apache.org/r/46255/diff/ > > > Testing > ------- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
