----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/ -----------------------------------------------------------
(Updated April 19, 2016, 3:19 p.m.) Review request for mesos, Adam B, Ben Mahler, and Vinod Kone. Changes ------- Replace UNREACHABLE with LOG(WARNING) based on review from Vinod. Bugs: MESOS-5031 https://issues.apache.org/jira/browse/MESOS-5031 Repository: mesos Description ------- This patch changes from `default` statement to explicit case statement (`UNKNOWN`) so that complier could help catching all switches when new enums are introduced in the future. This patch is related to: https://reviews.apache.org/r/45317/ (MESOS-5014) https://reviews.apache.org/r/45304/ (MESOS-5015) https://reviews.apache.org/r/45342/ (MESOS-5031) Diffs (updated) ----- src/authorizer/local/authorizer.cpp c744a16041c2466d3839a37fbee2bf86887bf4e1 src/cli/execute.cpp 087a73143d739f41638b8335c7e24dfcd14bc7fb src/examples/long_lived_framework.cpp c696ccb6b2ace6e047f6509b291dd14be240cf70 src/examples/test_http_executor.cpp ceb489d43f35d24c8a7f5fbb0148529745ee357a src/examples/test_http_framework.cpp 8cc3107034d46cb6a2966835f509508223c6e674 src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 src/master/master.cpp 6dacf5fbd73771e5c31ffb0e8723cd2905dcefb3 src/master/validation.cpp 0cd118ee4f89f749a063f6ba7f419d5a220dc1d4 src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c src/slave/validation.cpp ec1a4b6d9c55ab0c9894d5a49e290e15dee32c22 src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b Diff: https://reviews.apache.org/r/46364/diff/ Testing ------- make check (Ubuntu 14.04) Thanks, Yong Tang