> On 四月 21, 2016, 5:45 p.m., haosdent huang wrote: > > src/tests/containerizer/fs_tests.cpp, line 37 > > <https://reviews.apache.org/r/45500/diff/7/?file=1341124#file1341124line37> > > > > I think need remove this blank line.
are u sure? 36 using fs::FileSystemTable; 37 38 namespace mesos { - Deshi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45500/#review129929 ----------------------------------------------------------- On 四月 12, 2016, 11:49 a.m., Deshi Xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45500/ > ----------------------------------------------------------- > > (Updated 四月 12, 2016, 11:49 a.m.) > > > Review request for mesos, haosdent huang and Cong Wang. > > > Bugs: MESOS-1104 > https://issues.apache.org/jira/browse/MESOS-1104 > > > Repository: mesos > > > Description > ------- > > keep fs::mount information should be consolidated and moved to stout, > along with mount and umount. > > Refers to Benjamin Hindman's TODO: > https://github.com/apache/mesos/blob/0.22.1/src/linux/cgroups.cpp#L64 > > > Diffs > ----- > > src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 > src/linux/fs.hpp 5951f3f289552d65bc854074135f5177c052caf1 > src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f > src/slave/containerizer/mesos/mount.cpp > bf17b015e45579882fd31248e8609eec6d58a9da > src/tests/containerizer/fs_tests.cpp > 020fd8a4bf5911671e038a96f8b50c0f58e22ed5 > src/tests/containerizer/port_mapping_tests.cpp > 21ad1e1c53316a3bb6d914aa228ccf3658acdfbf > > Diff: https://reviews.apache.org/r/45500/diff/ > > > Testing > ------- > > make test on localhost(ubuntu) > > > Thanks, > > Deshi Xiao > >