> On April 22, 2016, 10:24 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/include/process/logging.hpp, lines 28-31 > > <https://reviews.apache.org/r/46258/diff/1/?file=1346275#file1346275line28> > > > > Don't we prefere trailing underscores?
For function parameters we use leading underscores; see the section on "Variable Names" in the style guide. > On April 22, 2016, 10:24 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/include/process/logging.hpp, line 59 > > <https://reviews.apache.org/r/46258/diff/1/?file=1346275#file1346275line59> > > > > Just wondering if it makes more sense to have a default 'None()' here > > and simplify the `initialize` function? In `initialize`, we need to call different `route` function overloads in each of the two `if ... else` branches, so we can't simplify that code too much by adding a default `None()` value here. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46258/#review130204 ----------------------------------------------------------- On April 15, 2016, 6:56 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46258/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 6:56 a.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-4902 > https://issues.apache.org/jira/browse/MESOS-4902 > > > Repository: mesos > > > Description > ------- > > This patch adds authentication to the `/logging/toggle` > HTTP endpoint on the master and agent. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/logging.hpp > 0c0774647d8048a9d8d395141a5864eadc64f8ef > 3rdparty/libprocess/src/logging.cpp > bdbf716ee46a459f1004f0f4b72c23aae135f347 > 3rdparty/libprocess/src/process.cpp > 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a > > Diff: https://reviews.apache.org/r/46258/diff/ > > > Testing > ------- > > `sudo make check` on OSX. > > > Thanks, > > Greg Mann > >
