----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46203/#review130788 -----------------------------------------------------------
Ship it! I'll fix the remamining issues and commit it for you shortly. src/slave/http.cpp (line 364) <https://reviews.apache.org/r/46203/#comment194681> Please indent by 4 spaces instead of 6. src/slave/http.cpp (line 807) <https://reviews.apache.org/r/46203/#comment194682> s/request/authorizationRequest src/slave/slave.hpp (lines 473 - 474) <https://reviews.apache.org/r/46203/#comment194683> Indent by 4 spaces. src/slave/slave.hpp (lines 476 - 477) <https://reviews.apache.org/r/46203/#comment194684> This looks like a trade-off between a doxygen-styled comment and a common comment. Let's make it look like a normal comment. src/tests/authorization_tests.cpp <https://reviews.apache.org/r/46203/#comment194686> It would have been great to have done this refactoring in a separate patch. src/tests/mesos.hpp (line 739) <https://reviews.apache.org/r/46203/#comment194687> It seems unfortunate that we inline such helpers. src/tests/slave_authorization_tests.cpp (lines 71 - 72) <https://reviews.apache.org/r/46203/#comment194688> Reformat to reduce jaggeddness. src/tests/slave_authorization_tests.cpp (lines 75 - 76) <https://reviews.apache.org/r/46203/#comment194689> Ditto. src/tests/slave_authorization_tests.cpp (line 82) <https://reviews.apache.org/r/46203/#comment194690> Extract endpoint as a constant. src/tests/slave_authorization_tests.cpp (line 90) <https://reviews.apache.org/r/46203/#comment194694> Let's abolish slavery in variable names. src/tests/slave_authorization_tests.cpp (line 133) <https://reviews.apache.org/r/46203/#comment194693> Ditto. src/tests/slave_authorization_tests.cpp (line 146) <https://reviews.apache.org/r/46203/#comment194695> Ditto. src/tests/slave_authorization_tests.cpp (lines 147 - 149) <https://reviews.apache.org/r/46203/#comment194696> Any reason you formatted this differently from the previous test? - Alexander Rukletsov On April 27, 2016, 2:32 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46203/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 2:32 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Bannier. > > > Bugs: MESOS-5142 > https://issues.apache.org/jira/browse/MESOS-5142 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/configuration.md 2796a812b72f2089999b1ae2d65a4ba843b50d70 > include/mesos/authorizer/acls.proto > c50deeb5565dfd5b3e5e7210283d9a36a3bfd579 > include/mesos/authorizer/authorizer.proto > 40d93ea257d1df8d22eee8a21667db90d579a8fe > src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca > src/authorizer/local/authorizer.cpp > 0a3805fe4ce8eb89e096e8cd4326035513ba892b > src/slave/flags.cpp a319d60c006d1104836c1c40f3617ceac9cb7b1e > src/slave/http.cpp 537736d1fe42e8150bad91326299ef9a17041a8e > src/slave/slave.hpp 57b18882e30e44dcc40449b0e3be8ee970c45bc8 > src/tests/authorization_tests.cpp d4ef0f94c86b1287c98671c5d478ce6ac3d90636 > src/tests/mesos.hpp 78edab89e6c13ff0892b2f3b5cb6886f08b02c82 > src/tests/slave_authorization_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46203/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_shuffle > ./bin/mesos-tests.sh --gtest_shuffle --gtest_repeat=100 > --gtest_filter=*SlaveAuthorization* > > > Thanks, > > Jan Schlicht > >