----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46875/#review131266 -----------------------------------------------------------
Patch looks great! Reviews applied: [46875] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 1, 2016, 6:52 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46875/ > ----------------------------------------------------------- > > (Updated May 1, 2016, 6:52 a.m.) > > > Review request for mesos, Adam B and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > There is no need to add () for request body as there is already > '' for the message. > > > Diffs > ----- > > src/master/weights_handler.cpp 07cc9920ca61f3e6e9e5b8be37884ed6f0d4f975 > > Diff: https://reviews.apache.org/r/46875/diff/ > > > Testing > ------- > > Before fix: > root@mesos002:~/test# curl -d weight.json -X PUT > http://192.168.56.12:5050/weights > Failed to parse update weights request JSON ('weight.json'): syntax error at > line 1 near: weight.js > > After fix: > root@mesos002:~/test# curl -d weight.json -X PUT > http://192.168.56.12:5050/weights > Failed to parse update weights request JSON 'weight.json': syntax error at > line 1 near: weight.json > > > Thanks, > > Guangya Liu > >